Skip to content

Deprecate JSON.Classify.classify #7315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Deprecate JSON.Classify.classify #7315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@

- Clean up legacy tags handling. https://github.com/rescript-lang/rescript/pull/7309

#### :nail_care: Polish

- Deprecate JSON.Classify.classify. https://github.com/rescript-lang/rescript/pull/7315

# 12.0.0-alpha.9

#### :boom: Breaking Change
Expand Down
1 change: 1 addition & 0 deletions runtime/Stdlib_JSON.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ module Classify = {
| Object(dict<t>)
| Array(array<t>)

@deprecated("Directly switch on the JSON object instead")
let classify = value => {
switch _internalClass(value) {
| "[object Boolean]" => Bool(_asBool(value))
Expand Down
1 change: 1 addition & 0 deletions runtime/Stdlib_JSON.resi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,7 @@ module Classify: {
// Number(42)
```
*/
@deprecated("Directly switch on the JSON object instead")
let classify: 'a => t
}

Expand Down