-
Notifications
You must be signed in to change notification settings - Fork 469
Stdlib: rename binary operations to match JavaScript terms #7353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bdeefad
to
ffb0149
Compare
👍 for cleaning up the naming/adapt it to JS terms. Some questions:
|
I simply didn't think it was necessary to hide the bitwise operations, so I adjusted them to be consistent across multiple modules.
Yeah it could be. If it becomes a common convention on the Stdlib surface, it's worth following. |
@zth What are your thoughts regarding function naming / the |
We already have |
ffb0149
to
1bf704e
Compare
1bf704e
to
4d51173
Compare
4d51173
to
7ad3f30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! 👍
Ah, sorry, need to ask about a CHANGELOG entry again. |
Merging as is, will add the CHANGELOG entry while preparing the release. |
* Stdlib: rename binary operations to match JavaScript terms * rename shift operations * remove old name * update analysis result
So on