Add completions for included modules #7509
Conversation
| open Types | ||
|
|
||
| @send | ||
| external addPos: (context, float, float) => comp = "pos" |
There was a problem hiding this comment.
This becomes available in Wall after its inclusion.
|
|
||
| let make = () => { | ||
| [ | ||
| // k. |
There was a problem hiding this comment.
We should be able to complete k->addPos and k->addPosFromVec2.
| @@ -357,6 +357,7 @@ let completePipeChain ~(inJsxContext : bool) (exp : Parsetree.expression) = | |||
|
|
|||
| let completionWithParser1 ~currentFile ~debug ~offset ~path ~posCursor | |||
| ?findThisExprLoc text = | |||
| let cursorPath = Stack.create () in | |||
There was a problem hiding this comment.
I'm trying to keep track of which nested modules we have visited so far.
So, I can construct the current path of the cursor.
| @@ -1180,8 +1182,17 @@ and getCompletionsForContextPath ~debug ~full ~opens ~rawOpens ~pos ~env ~exact | |||
| |> TypeUtils.filterPipeableFunctions ~synthetic:true ~env ~full | |||
| ~targetTypeId:mainTypeId | |||
| in | |||
| (* Add completions from current fully qualified path module *) | |||
There was a problem hiding this comment.
Here, I use the cursorPath collected via the frontend, to ask for DotPipeCompleteFromCurrentModule.Wall completions.
This is the only way I get the addPos and addPosFromVec2 completions.
There was a problem hiding this comment.
This, of course, doesn't take into account functions defined after the cursor.
So that is not ideal.
It also proposes fully qualified function calls instead of having no path at all.
I'm a little stuck on this one, could use a pointer @zth if you have any ideas.