Skip to content

delay the external module dependency check, so we can decide whehter … #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2016

Conversation

bobzhang
Copy link
Member

@bobzhang bobzhang commented Feb 5, 2016

…we need curry support in one pass

bobzhang added a commit that referenced this pull request Feb 5, 2016
delay the external module dependency check, so we can decide whehter …
@bobzhang bobzhang merged commit b108b85 into master Feb 5, 2016
@bobzhang bobzhang deleted the sort_modules_deps branch February 5, 2016 16:46
EduardoRFS pushed a commit to EduardoRFS/bucklescript that referenced this pull request Apr 5, 2021
…lang#80)

In order to track dynamic dependencies we were:
1. reading each `*.d` file produced by `bsb_helper`
2. for each dependency in the `*.d` file, track it in dune by reading
   their file contents

We can avoid reading files into memory altogether by calling the
`read_directory_with_glob` function instead, which declares dependencies
on those files without reading their contents.
kevinbarabash pushed a commit to kevinbarabash/rescript-compiler that referenced this pull request Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant