This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Don't parse Int token with suffices as hash ident for poly variants #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`#10s` should not be accepted as a numeric polyvariant identifier. Fixes #407
bloodyowl
reviewed
May 9, 2021
|
maybe a good time to turn on warning 9 to avoid it in the future? |
|
Yes, thanks for the suggestion, will do! |
Co-authored-by: Matthias Le Brun <[email protected]>
Closed
IwanKaramazow
commented
May 13, 2021
| 2 │ | ||
| 3 │ type t = [ #red | #10s ] | ||
|
|
||
| A numeric polymorphic variant cannot be followed by a letter. Did you mean `#10`? |
There was a problem hiding this comment.
@bloodyowl what do you think of this new message? Specialized it to give a clear suggestion on what the user could do in this case.
There was a problem hiding this comment.
Yup, that looks better 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10sshould not be accepted as a numeric polyvariant identifier.Fixes #407