This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Print punned fields #480
Merged
Print punned fields #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Punning | ||
| let r = {a} // actually not a record, just an expression in braces | ||
| let r = {a, b} |
There was a problem hiding this comment.
Can you add an extra test case with all kind of different comments on punned key-values?
There was a problem hiding this comment.
Added some, looks good to me.
| @@ -2815,7 +2819,7 @@ and printExpression (e : Parsetree.expression) cmtTbl = | |||
| Doc.softLine; | |||
| spread; | |||
| Doc.join ~sep:(Doc.concat [Doc.text ","; Doc.line]) | |||
| (List.map (fun row -> printRecordRow row cmtTbl) rows) | |||
| (List.map (fun row -> printRecordRow row cmtTbl punningAllowed) rows) | |||
There was a problem hiding this comment.
Instead of passing punningAllowed to every row, would it be "clearer" if we special cased the one-element record?
// pseudo-code
if (one-element-record) {
…
} else {
List.map printRecordRow…
}What do you think about this?
There was a problem hiding this comment.
Just tried that here: cknitt@d83c61f
Do you think it is an improvement?
IwanKaramazow
approved these changes
Apr 18, 2022
There was a problem hiding this comment.
@cknitt Thanks for the improvements, good to ship! Sorry for the delay.
This was referenced May 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the printer removes record field punning as discussed in #252 (for record expressions) and #47 (for record type declarations). I.e., it expands
{a, b}to{a: a, b: b}.I gather from the discussions that we want to leave the behavior for record type declarations as it is, but improve the behavior for record expressions. This PR addresses that.
To avoid breaking changes for now, the printer will keep record expressions as the user wrote them, whether punned or not. That is,
{a, b}will remain{a, b}and{a: a, b: b}will remain{a: a, b: b}.