This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Fix type error by Jsx.addKeyProp
for the empty props
#641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #640 (comment)
The issue is the props type is not matched in case of empty props.
The solution is using
React.createElementWithKey
instead ofJsx.addKeyProp
.React.createElementWithKey
rescript-lang/rescript-react@a4c31f8Jsx.addKeyProp
Add the return type constraint forJsx.addKeyProp
rescript#5670