Skip to content

chore: migrate to rescript #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cem2ran
Copy link
Contributor

@cem2ran cem2ran commented May 7, 2021

Spent a few minutes migrating this. Used rescript convert src/**/*.re. This converted everything except class types as mentioned in #42. I've converted the classes to the new object spread syntax.

Haven't tested whether this works, as I currently don't use this at work, maybe someone else can test this draft PR and bring it to the finish line.

scripts in Package.json should probably be updated further, e.g. format.

@Freddy03h
Copy link
Member

Hi! I finally had time to migrate my app to latest rescript dependencies and test this PR on a real project.

It work well thank you 😊

The only missing part that I think it's still useful are the @obj options functions in Navigators (bottomaTabBarOptions()in BottomTabs, materialTopTabBarOptions() in MaterialTopTabs, …) because it's not yet possible to create Object without specifying option('a) attributes.

@MoOx
Copy link
Member

MoOx commented Jun 20, 2021

Thanks for this PR. I tried conversion a few months ago, but virtual class where being dropped entirely... It seems here there is something to cover this.

@Freddy03h if you have time, we can merge this in a wip branch & you can continue contributing from here. Sounds good to you ?

@MoOx
Copy link
Member

MoOx commented Aug 23, 2021

@Freddy03h up to continue the migration? or @cem2ran do you have time for this?

@Freddy03h Freddy03h changed the base branch from main to rescript-migration August 27, 2021 15:13
@Freddy03h Freddy03h marked this pull request as ready for review August 27, 2021 15:14
@Freddy03h Freddy03h merged commit 8b9c852 into rescript-react-native:rescript-migration Aug 27, 2021
@Freddy03h Freddy03h mentioned this pull request Aug 27, 2021
MoOx pushed a commit that referenced this pull request Sep 18, 2021
* chore: migrate to rescript (#44)

fixes #42

* fix bottomTabBarProps instead of bottomTabBarOptions

* add materialTopTabBarOptions and bottomTabBarOptions creation functions

Co-authored-by: Cem Turan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants