Skip to content

Fix navigateBy* functions #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vknez
Copy link
Contributor

@vknez vknez commented Sep 20, 2021

The underlying navigateBy function didn't accept navigation, so it wasn't working. I wired up the navigation param in navigateByKey and navigateByName.

- `navigateBy` didn't accept `navigation`
@MoOx
Copy link
Member

MoOx commented Sep 20, 2021

Nice, thanks!

@MoOx MoOx merged commit b89bf1e into rescript-react-native:main Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants