Fix for #215. Allow delegate_attribute for derived classes

CHANGELOG.md

@@ -4,6 +4,7 @@
 * [#215](https://github.com/ruby-grape/grape-entity/pull/217): Fix: `#delegate_attribute` no longer delegates to methods included with `Kernel` - [@maltoe](https://github.com/maltoe).
 * [#219](https://github.com/ruby-grape/grape-entity/pull/219): Fix: double pass options in serializable_hash - [@sbatykov](https://github.com/sbatykov).
 * [#226](https://github.com/ruby-grape/grape-entity/pull/226): Add fetch method to fetch from opts_hash - [@alanjcfs](https://github.com/alanjcfs).
+* [#231](https://github.com/ruby-grape/grape-entity/pull/231): Fix for [#215](https://github.com/ruby-grape/grape-entity/pull/217) allow delegate_attribute for derived entity - [@sbatykov](https://github.com/sbatykov).
 * Your contribution here.
 
 0.5.1 (2016-4-4)

lib/grape_entity/entity.rb

@@ -478,7 +478,7 @@ def value_for(key, options = Options.new)
     end
 
     def delegate_attribute(attribute)
-      if respond_to?(attribute, true) && method(attribute).owner == self.class
+      if respond_to?(attribute, true) && Grape::Entity > method(attribute).owner
         send(attribute)
       else
         delegator.delegate(attribute)

spec/grape_entity/entity_spec.rb

@@ -1523,12 +1523,13 @@ class FriendEntity < Grape::Entity
         expect(subject.value_for(:fantasies)).to eq ['Nessy', 'Double Rainbows', 'Unicorns']
       end
 
-      it 'tries instance methods on the entity first' do
+      context 'delegate_attribute' do
         module EntitySpec
           class DelegatingEntity < Grape::Entity
             root 'friends', 'friend'
             expose :name
             expose :email
+            expose :system
 
             private
 
@@ -1538,26 +1539,33 @@ def name
           end
         end
 
-        friend = double('Friend', name: 'joe', email: '[email protected]')
-        rep = EntitySpec::DelegatingEntity.new(friend)
-        expect(rep.value_for(:name)).to eq 'cooler name'
-        expect(rep.value_for(:email)).to eq '[email protected]'
+        it 'tries instance methods on the entity first' do
+          friend = double('Friend', name: 'joe', email: '[email protected]')
+          rep = EntitySpec::DelegatingEntity.new(friend)
+          expect(rep.value_for(:name)).to eq 'cooler name'
+          expect(rep.value_for(:email)).to eq '[email protected]'
 
-        another_friend = double('Friend', email: '[email protected]')
-        rep = EntitySpec::DelegatingEntity.new(another_friend)
-        expect(rep.value_for(:name)).to eq 'cooler name'
-      end
+          another_friend = double('Friend', email: '[email protected]')
+          rep = EntitySpec::DelegatingEntity.new(another_friend)
+          expect(rep.value_for(:name)).to eq 'cooler name'
+        end
+
+        it 'does not delegate Kernel methods' do
+          foo = double 'Foo', system: 'System'
+          rep = EntitySpec::DelegatingEntity.new foo
+          expect(rep.value_for(:system)).to eq 'System'
+        end
 
-      it 'does not delegate to Kernel methods' do
         module EntitySpec
-          class DelegatingEntity < Grape::Entity
-            expose :system
+          class DerivedEntity < DelegatingEntity
           end
         end
 
-        foo = double 'Foo', system: 'System'
-        rep = EntitySpec::DelegatingEntity.new foo
-        expect(rep.value_for(:system)).to eq 'System'
+        it 'derived entity get methods from base entity' do
+          foo = double 'Foo', name: 'joe'
+          rep = EntitySpec::DerivedEntity.new foo
+          expect(rep.value_for(:name)).to eq 'cooler name'
+        end
       end
 
       context 'using' do