Treat Symbol as string in params parsing #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh, no... How do I fix it? |
|
For Rubocop, just run |
|
This also needs a CHANGELOG entry please. You should write a higher level integration test, too (something about the API and the generated swagger doc). |
ypresto
force-pushed
the
symbol-as-string
branch
from
ac1ec5a to
f180ce6
Compare
|
Added test for generated doc, and CHANGELOG :) |
|
Looks great! |
dblock
added a commit
that referenced
this pull request
Feb 1, 2015
Treat Symbol as string in params parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type: Symbolis sometimes useful when accepting enum params.Currently this library treats it as custom data type sent as body, but it must be same as string in layer of http.
This PR make Symbol treated as string in swagger doc (with only 2 lines!).
Thanks for great product :)