Remove section "Setting a Swagger defaultValue" from readme #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger does not have a parameter example definition, then the example value does not show on swagger-ui.
|
This was added in https://github.com/tim-vandecasteele/grape-swagger/pull/223 via https://github.com/tim-vandecasteele/grape-swagger/issues/215. So who is right? :) cc: @jv-dan |
|
Yeah, I was told using the real swagger property defaultValue was confusing compared to grapes default, but example does populate swagger's defaultValue property without setting a default value on grapes end when the parameter is empty. |
Closed
|
please re-target against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swagger does not have a parameter example definition, then the example value does not show on swagger-ui.