Added support for set the 'collectionFormat' of arrays #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rczjns
force-pushed
the
collection-format-support
branch
3 times, most recently
from
9e972ce to
6468037
Compare
|
@rczjns … thanks for it, please rebase it |
rczjns
force-pushed
the
collection-format-support
branch
from
19fe6c6 to
4920024
Compare
|
@LeFnord I've rebased it and OK I've kept it without default value. |
LeFnord
pushed a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support to be able to set the collection format based on swagger specification ( http://swagger.io/specification/#itemsObject ). Now I set the parameter only if it present in the documentation hash, because the default value could be possible braking change.
But I think we could use the default 'csv' format to every arrays. If you agree with that, I will modify my pull request.