The guard method should not just pass the second item as a string. #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you want to use the guard method as instructed in the readme, you will actually pass the string “false” to the oauth2 method, iso actually passing `false`. As this is a user added string, we should just instance_eval it. This is clearly made to be used with wine_bouncer, but in the current implementation I so no way possible to actually pass false (so make wine_bouncer see this as public iso the scope :false)
tim-vandecasteele
force-pushed
the
eval-guard
branch
from
007af5f to
43621f6
Compare
|
thanks @tim-vandecasteele … |
|
@LeFnord, @tim-vandecasteele, I am currently abroad in vacation, will return home January, 10 and will take a look after this. |
|
it seems to be ok |
LeFnord
pushed a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
…uby-grape#562) If you want to use the guard method as instructed in the readme, you will actually pass the string “false” to the oauth2 method, iso actually passing `false`. As this is a user added string, we should just instance_eval it. This is clearly made to be used with wine_bouncer, but in the current implementation I so no way possible to actually pass false (so make wine_bouncer see this as public iso the scope :false)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to use the guard method as instructed in the readme, you will actually pass the string “false” to the oauth2 method, iso actually passing
false. As this is a user added string, we should just instance_eval it.This is clearly made to be used with wine_bouncer, but in the current implementation I so no way possible to actually pass false (so make wine_bouncer see this as public iso the scope :false)
This does change the current behaviour though!