Skip to content

safer conversion of grape accepted types to swagger types #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jdoconnor
Copy link

This allows for the grape accepted param type 'Boolean' to be converted properly to a swagger type. The issue is that the full type of a Boolean includes the Virtus namespace. This can probably be extracted for other Virtus types

@tim-vandecasteele
Copy link
Contributor

Looks like the tests are failing in this branch. If you still want this in, can you make tests succeed (and rebase on master)

@jdoconnor
Copy link
Author

@tim-vandecasteele good to go! Thanks for reviewing.

@taybin
Copy link
Contributor

taybin commented Jul 11, 2014

Please merge this next. I've run into this problem.

@dblock
Copy link
Member

dblock commented Jul 11, 2014

@jdoconnor You should rebase if you see this. Thanks.

@jdoconnor
Copy link
Author

@dblock rebased. tests passing. I haven't been keeping up to know if this was still a problem or not. hopefully this unblocks those that need it.

@dblock
Copy link
Member

dblock commented Jul 14, 2014

What's missing here is a test for the Virtus type. You're adding functionality, it should be tested :)

@dblock dblock added bug? and removed needs help labels Jul 14, 2014
@elado
Copy link
Contributor

elado commented Aug 29, 2014

👍

@sethherr
Copy link

I believe this can be closed, fixed from #168.

@jdoconnor
Copy link
Author

agree.

@jdoconnor jdoconnor closed this Jan 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants