add the swagger_endpoint_guard to both documentation endpoints #737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
urkle
force-pushed
the
fix-swagger-endpoint-guard
branch
3 times, most recently
from
9a96a67 to
8ba9870
Compare
urkle
force-pushed
the
fix-swagger-endpoint-guard
branch
from
8ba9870 to
69fd941
Compare
|
I feel like this changes behavior and breaks backwards compatibility. What are the consequences of this change? Does this need README and/or UPGRADING edits? |
|
think it only completes/corrects behaviour, so for both grape-swagger endpoints it will be checked if an gurad clause exists … @urkle, please correct me, if I'm wrong |
|
I see, it's just a fix. Let's just merge it. |
LeFnord
pushed a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
add the swagger_endpoint_guard to both documentation endpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the swagger_endpoint_guard to both documentation endpoints.