Skip to content

Replace downcase with underscore for multi-word roots #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 3, 2020
Merged

Replace downcase with underscore for multi-word roots #764

merged 3 commits into from
Jan 3, 2020

Conversation

bikolya
Copy link
Contributor

@bikolya bikolya commented Oct 30, 2019

It fixes a problem introduced in #761
When downcase was used, apierror instead of api_error was generated from ApiError entity.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 98.853% when pulling c298c26 on bikolya:fix-underscored-root into 294740b on ruby-grape:master.

5 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 98.853% when pulling c298c26 on bikolya:fix-underscored-root into 294740b on ruby-grape:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 98.853% when pulling c298c26 on bikolya:fix-underscored-root into 294740b on ruby-grape:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 98.853% when pulling c298c26 on bikolya:fix-underscored-root into 294740b on ruby-grape:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 98.853% when pulling c298c26 on bikolya:fix-underscored-root into 294740b on ruby-grape:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 98.853% when pulling c298c26 on bikolya:fix-underscored-root into 294740b on ruby-grape:master.

@coveralls
Copy link

coveralls commented Oct 30, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 99.479% when pulling 4c4d96f on bikolya:fix-underscored-root into 4559093 on ruby-grape:master.

@bikolya bikolya force-pushed the fix-underscored-root branch from c298c26 to 40669ac Compare October 30, 2019 12:19
@bikolya bikolya force-pushed the fix-underscored-root branch from 40669ac to 2dc14f3 Compare October 30, 2019 13:40
@LeFnord
Copy link
Member

LeFnord commented Dec 15, 2019

thanks … @bikolya, welcome 😄

and sorry for late replay

@grape-bot
Copy link

grape-bot commented Jan 3, 2020 •
edited
Loading

1 Error
🚫 One of the lines below found in CHANGELOG.md doesn’t match the expected format. Please make it look like the other lines, pay attention to periods and spaces. 
* [#749](https://github.com/ruby-grape/grape-swagger/pull/749) Drop support for Ruby 2.3 and below - [@LeFnord](https://github.com/LeFnord).
* [#749](https://github.com/ruby-grape/grape-swagger/pull/749) Drop support for Ruby 2.3 and below - [@LeFnord](https://github.com/LeFnord).

Generated by 🚫 danger

@ruby-grape ruby-grape deleted a comment from grape-bot Jan 3, 2020
@LeFnord LeFnord merged commit 2c630b3 into ruby-grape:master Jan 3, 2020
@dblock
Copy link
Member

dblock commented Jan 3, 2020

The CHANGELOG complaint is right, you're missing a colon after the PR :)

@LeFnord
Copy link
Member

LeFnord commented Jan 3, 2020

ah ok … thanks

@dblock dblock mentioned this pull request Jan 3, 2020
Open
aka-momo pushed a commit to aka-momo/grape-swagger that referenced this pull request Feb 8, 2023
@bikolya @LeFnord @aka-momo
Replace downcase with underscore for multi-word roots (ruby-grape#764)
2cf19e1 
Co-authored-by: peter scholz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bikolya @coveralls @LeFnord @grape-bot @dblock