Skip to content

allow token_owner to be passed to the hidden proc for parameters as well #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

urkle
Copy link
Contributor

@urkle urkle commented Jan 23, 2020

This allows the same functionality that is offered by the route-level hidden procs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 99.671% when pulling 3b76755 on urkle:feat-token_owner-for-params-parser-hidden into 11d29c4 on ruby-grape:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 99.671% when pulling 3b76755 on urkle:feat-token_owner-for-params-parser-hidden into 11d29c4 on ruby-grape:master.

@coveralls
Copy link

coveralls commented Jan 23, 2020

Coverage Status

Coverage decreased (-0.1%) to 99.56% when pulling 1994b05 on urkle:feat-token_owner-for-params-parser-hidden into 11d29c4 on ruby-grape:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 99.671% when pulling 3b76755 on urkle:feat-token_owner-for-params-parser-hidden into 11d29c4 on ruby-grape:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 99.671% when pulling 3b76755 on urkle:feat-token_owner-for-params-parser-hidden into 11d29c4 on ruby-grape:master.

@urkle urkle force-pushed the feat-token_owner-for-params-parser-hidden branch from 3b76755 to 6e0c6ab Compare January 23, 2020 23:09
@urkle urkle requested a review from LeFnord January 23, 2020 23:09
@urkle urkle force-pushed the feat-token_owner-for-params-parser-hidden branch 2 times, most recently from 9656e95 to 2b3e4f0 Compare January 24, 2020 13:50
@urkle urkle force-pushed the feat-token_owner-for-params-parser-hidden branch from 2b3e4f0 to 1994b05 Compare January 24, 2020 14:08
@grape-bot
Copy link

grape-bot commented Jan 24, 2020

1 Error
🚫 One of the lines below found in CHANGELOG.md doesn’t match the expected format. Please make it look like the other lines, pay attention to periods and spaces.
* [#749](https://github.com/ruby-grape/grape-swagger/pull/749) Drop support for Ruby 2.3 and below - [@LeFnord](https://github.com/LeFnord).

Generated by 🚫 danger

@LeFnord
Copy link
Member

LeFnord commented Feb 9, 2020

thanks @urkle … will be mörged

@LeFnord LeFnord merged commit 8abddd5 into ruby-grape:master Feb 9, 2020
@urkle urkle deleted the feat-token_owner-for-params-parser-hidden branch June 9, 2020 15:10
aka-momo pushed a commit to aka-momo/grape-swagger that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants