-
Notifications
You must be signed in to change notification settings - Fork 476
Allow entity_name to be called on parent classes #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0fe0a77
to
3054e03
Compare
* [#794](https://github.com/ruby-grape/grape-swagger/pull/794): Allow entity_name to be inherited, fixes #659 - [@urkle](https://githubcom/urkle). Generated by 🚫 danger |
3054e03
to
fefb809
Compare
LeFnord
reviewed
Jun 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @urkle … it seems this is always WIP … 😉
fefb809
to
e2aa8ea
Compare
@urkle … please can you have a look on it, want have it in in trhe next release |
f0a0063
to
b26a051
Compare
This resolves issue ruby-grape#659.
b26a051
to
b1f6d22
Compare
@LeFnord I re-based retested and corrected the rubocop issues |
cool thanks @urkle |
aka-momo
pushed a commit
to aka-momo/grape-swagger
that referenced
this pull request
Feb 8, 2023
This resolves issue ruby-grape#659.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am unsure why this limitation was done and issue #659 posses the same question.
This PR changes the behavior to allow calling entity_name if a parent class implements it.
My use case for this as follows
And I have ~ 20+ entities all inheriting from base and I don't really want the FULL module tree exposed in the API (in our application it is a little longer than what you see here). And being able to override entity_name once is significantly easier.