Corrected the related parameter lookup on request params. #822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What is it good for
There is a nasty bug while using grape-swagger on request parameters that share the same base name in any way (eg.
ids
anduser_ids
) which results in a missing parameter and a badly named on (eg.ids
is missing, whileuser_ids[][]
is renamed to). An example Grape API class looks like this:- What I did
I just changed the related parameter matching to use
start_with?
instead ofinclude?
to be sure that the related parameter is not accidentally matched while respecting actual matches. (eg.user_id
anduser_id[id]
)- A picture of a cute animal (not mandatory but encouraged)