-
Notifications
You must be signed in to change notification settings - Fork 476
Parse route_param type for nested endpoints #847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dmoss18 for the fix
please can you change the specs … maybe they are running only if grape '~> 1.6' is loaded or so
@LeFnord I'm having a hard time getting Ruby version Do you have any tips I could try to get these tests to fail like they do in CI? |
thanks @dmoss18 |
* Fix documentation of `route_param` type when used with nested endpoints * Rubocop fixes * Rubocop fixes * grape 1.6 Co-authored-by: peter scholz <[email protected]>
* Fix documentation of `route_param` type when used with nested endpoints * Rubocop fixes * Rubocop fixes * grape 1.6 Co-authored-by: peter scholz <[email protected]>
We noticed that when we did this:
The type of
account_number
is defaulted tointeger
. Grape doesn't include anyoptions
indeclared_params
, so this code parses any parent namespaces and builds a mappingdeclared_params
to theiroptions
.