Skip to content

Add Support for default response. #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2023

Conversation

dhruvCW
Copy link
Contributor

@dhruvCW dhruvCW commented Aug 21, 2022

add support for default as a response code as specified in https://swagger.io/docs/specification/2-0/describing-responses/ Default Response section.

thus allowing for specifying a model that corresponds to all http status codes that are not specifically mentioned.

@dhruvCW dhruvCW force-pushed the add-default-response branch 2 times, most recently from cff7775 to 73f0b7f Compare August 28, 2022 13:03
@dhruvCW dhruvCW force-pushed the add-default-response branch from a80066c to 73f0b7f Compare January 12, 2023 13:21
support default as a response code as specified in https://swagger.io/docs/specification/2-0/describing-responses/ Default Response section.
@dhruvCW dhruvCW force-pushed the add-default-response branch from 56a8841 to 3d3f84e Compare February 27, 2023 13:48
@dhruvCW
Copy link
Contributor Author

dhruvCW commented Feb 27, 2023

hello maintainers (@LeFnord)👋

could this be reviewed please ? is it worth merging ?

@LeFnord
Copy link
Member

LeFnord commented Feb 27, 2023

first thanks @dhruvCW

please can you add a CHANGELOG entry and a Routes Configuration entry in the README, thanks

@LeFnord
Copy link
Member

LeFnord commented Feb 27, 2023

and yeah … your PR is very welcome :)

@dhruvCW
Copy link
Contributor Author

dhruvCW commented Mar 17, 2023

please can you add a CHANGELOG entry and a Routes Configuration entry in the README, thanks

added documentation to the README and CHANGELOG entry.

@LeFnord
Copy link
Member

LeFnord commented Mar 19, 2023

thanks @dhruvCW

@LeFnord LeFnord merged commit 49fed72 into ruby-grape:master Mar 19, 2023
@dhruvCW dhruvCW deleted the add-default-response branch May 8, 2023 10:59
Bhacaz pushed a commit to Bhacaz/grape-swagger that referenced this pull request Aug 31, 2023
* Add Support for default response.

support default as a response code as specified in https://swagger.io/docs/specification/2-0/describing-responses/ Default Response section.

* add docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants