Skip to content

Commit 87c88e4

Browse files
NikolayRysdblock
authored andcommitted
Drop old appraisals (#1916)
1 parent deeb826 commit 87c88e4

File tree

5 files changed

+1
-86
lines changed

5 files changed

+1
-86
lines changed

Appraisals

-9
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,3 @@
1-
appraise 'rails-3' do
2-
gem 'rails', '3.2.22.5'
3-
gem 'rack-cache', '<= 1.2' # Pin as next rack-cache version (1.3) removes Ruby1.9 support
4-
end
5-
6-
appraise 'rails-4' do
7-
gem 'rails', '4.2.10'
8-
end
9-
101
appraise 'rails-5' do
112
gem 'rails', '5.2.1'
123
end

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#### Fixes
1212

1313
* Your contribution here.
14+
* [#1916](https://github.com/ruby-grape/grape/pull/1916): Drop old appraisals - [@NikolayRys](https://github.com/NikolayRys).
1415
* [#1911](https://github.com/ruby-grape/grape/pull/1911): Make sure `Grape::Valiations::AtLeastOneOfValidator` properly treats nested params in errors - [@dnesteryuk](https://github.com/dnesteryuk).
1516
* [#1893](https://github.com/ruby-grape/grape/pull/1893): Allows `Grape::API` to behave like a Rack::app in some instances where it was misbehaving - [@myxoh](https://github.com/myxoh).
1617
* [#1898](https://github.com/ruby-grape/grape/pull/1898): Refactor `ValidatorFactory` to improve memory allocation - [@Bhacaz](https://github.com/Bhacaz).

gemfiles/rails_3.gemfile

-36
This file was deleted.

gemfiles/rails_4.gemfile

-35
This file was deleted.

spec/grape/integration/rack_spec.rb

-6
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,6 @@
1919
}
2020
env = Rack::MockRequest.env_for('/', options)
2121

22-
unless RUBY_PLATFORM == 'java'
23-
major, minor, patch = Rack.release.split('.').map(&:to_i)
24-
patch ||= 0 # rack <= 1.5.2 does not specify patch version
25-
pending 'Rack 1.5.3 or 1.6.1 required' unless major >= 2 || (major >= 1 && ((minor == 5 && patch >= 3) || (minor >= 6)))
26-
end
27-
2822
expect(JSON.parse(app.call(env)[2].body.first)['params_keys']).to match_array('test')
2923
ensure
3024
input.close

0 commit comments

Comments
 (0)