Drop old appraisals #1916
Merged
Drop old appraisals #1916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 3 and 4 appraisals are excluded from travis build a long time ago, while recent rack changes made them completely incompatible.
Since rails_3 appraisal is dropped, the workaround(which wasn't implemented correctly either) can be removed.
Generated by 🚫 danger |
dblock
reviewed
Oct 14, 2019
| @@ -11,6 +11,7 @@ | |||
| #### Fixes | |||
|
|
|||
| * Your contribution here. | |||
| * [#1916](https://github.com/ruby-grape/grape/pull/1916): Drop old appraisals - [@NikolayRys](https://github.com/NikolayRys). | |||
There was a problem hiding this comment.
Nitpick: be explicit? How about "drop Rails 3 and 4 support"? If we're no longer testing, we aren't supporting.
There was a problem hiding this comment.
No, probs, I reword it, but initially my assumption was that you don't support for a long time(since you have removed them from the travis build), so what I did was just a clean-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 3 and 4 appraisals have been excluded from travis build for a year: 9c942f4#diff-354f30a63fb0907d4ad57269548329e3
The recent update to rack-test: https://github.com/ruby-grape/grape/pull/1912/files#diff-0bd0610801e75105f6818e38cc85c172 made the appraisals for rails_3 and rails_4 harder to fix, because they use old rack-spec of their own.
Probably it's time to get rid of them. It will allow to run cleanly run
appraisal rake spec.Please, let me know what you think.
UPD: also removing a work-around specific for rails_3 in
spec/grape/integration/rack_spec.rbMore details: 3115c6e