Grape v1.4.0 regression: Cache-Control is always set to no-cache

[stanhu]

In Grape v1.4.0 https://github.com/ruby-grape/grape/pull/1520/files#diff-8e15cddb80f42ca7d43872846d80ecbeR275 broke our test suite because Cache-Control is always set to no-cache in

grape/lib/grape/dsl/inside_route.rb

Line 333 in 84d68bd

header 'Cache-Control', 'no-cache' # Skips ETag generation (reading the response up front)

.

We set Cache-Control to max-age=0, private, must-revalidate, no-store, no-cache.

Maybe we should appendno-cache only if isn't present? Or maybe the headers shouldn't be touched if nil is returned?

[stanhu]

I'm also not sure if overriding the Content-Length and Transfer-Encoding by default creates other issues.

[jarthod]

Got the exact same problem. Good to see it's already fixed 👏 waiting for the next release then ;)