Skip to content

Use Ruby 2.3.0 on Travis #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2016
Merged

Use Ruby 2.3.0 on Travis #1234

merged 2 commits into from
Jan 3, 2016

Conversation

namusyaka
Copy link
Contributor

Ruby 2.3 is now available.

@namusyaka
Copy link
Contributor Author

The errors can be resolved by this commit

@ArnonHongklay
Copy link

@namusyaka travis ci not complete

@namusyaka
Copy link
Contributor Author

The errors have been occured by stopping to rescue exceptions of <=>.
So I fixed a problem by modifing a code in cookiejar, but the gem has not been maintained for quite a while.

@nonmadden Really? That seems to be completed, but failed.

@ArnonHongklay
Copy link

not clearly you say completed but failed ???

@dblock
Copy link
Member

dblock commented Jan 3, 2016

@namusyaka I read rails/rails@0599bfa, try altering the spec to work in both versions and we don't have to wait for an update to cookiejar? Thanks for making a PR there, too.

@namusyaka
Copy link
Contributor Author

@dblock I noticed I overlooked rails-3.2.22 release.
So I tried to update the dependency and tests seem to be working well. How about this one?

dblock added a commit that referenced this pull request Jan 3, 2016
@dblock dblock merged commit 90c3391 into ruby-grape:master Jan 3, 2016
@dblock
Copy link
Member

dblock commented Jan 3, 2016

Merged, thanks!

@namusyaka namusyaka deleted the use-ruby2.3 branch January 4, 2016 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants