Skip to content

Fix build: upgraded and locked version of Rubocop. #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,23 +1,22 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2016-12-01 19:41:18 +0100 using RuboCop version 0.46.0.
# on 2017-01-17 06:04:25 -0500 using RuboCop version 0.47.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 3
# this must be removed for preparation of ruby 2.4
Lint/UnifiedInteger:
Exclude:
- 'lib/grape/dsl/inside_route.rb'
- 'spec/grape/validations/validators/allow_blank_spec.rb'

# Offense count: 44
Metrics/AbcSize:
Max: 44

# Offense count: 266
# Configuration parameters: CountComments, ExcludedMethods.
Metrics/BlockLength:
Max: 3084

# Offense count: 1
# Configuration parameters: CountBlocks.
Metrics/BlockNesting:
Max: 4

Expand All @@ -30,13 +29,13 @@ Metrics/ClassLength:
Metrics/CyclomaticComplexity:
Max: 14

# Offense count: 964
# Offense count: 975
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
Max: 215

# Offense count: 55
# Offense count: 54
# Configuration parameters: CountComments.
Metrics/MethodLength:
Max: 33
Expand All @@ -50,6 +49,12 @@ Metrics/ModuleLength:
Metrics/PerceivedComplexity:
Max: 14

# Offense count: 2
Style/IdenticalConditionalBranches:
Exclude:
- 'lib/grape/dsl/desc.rb'

# Offense count: 1
Style/MethodMissing:
Exclude:
- 'lib/grape/router/attribute_translator.rb'
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gemspec
group :development, :test do
gem 'bundler'
gem 'rake'
gem 'rubocop', '~> 0.45'
gem 'rubocop', '0.47.0'
end

group :development do
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rack_1.5.2.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem 'rack', '1.5.2'
group :development, :test do
gem 'bundler'
gem 'rake'
gem 'rubocop', '~> 0.45'
gem 'rubocop', '0.47.0'
end

group :development do
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rack_edge.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem 'rack', github: 'rack/rack'
group :development, :test do
gem 'bundler'
gem 'rake'
gem 'rubocop', '~> 0.45'
gem 'rubocop', '0.47.0'
end

group :development do
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rails_3.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ gem 'rack-cache', '<= 1.2'
group :development, :test do
gem 'bundler'
gem 'rake'
gem 'rubocop', '~> 0.45'
gem 'rubocop', '0.47.0'
end

group :development do
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rails_4.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem 'rails', '4.1.6'
group :development, :test do
gem 'bundler'
gem 'rake'
gem 'rubocop', '~> 0.45'
gem 'rubocop', '0.47.0'
end

group :development do
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rails_5.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem 'rails', '5.0.0'
group :development, :test do
gem 'bundler'
gem 'rake'
gem 'rubocop', '~> 0.45'
gem 'rubocop', '0.47.0'
end

group :development do
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rails_edge.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem 'arel', github: 'rails/arel'
group :development, :test do
gem 'bundler'
gem 'rake'
gem 'rubocop', '~> 0.45'
gem 'rubocop', '0.47.0'
end

group :development do
Expand Down
6 changes: 2 additions & 4 deletions spec/grape/validations/types_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,11 @@
describe Grape::Validations::Types do
module TypesSpec
class FooType
def self.parse(_)
end
def self.parse(_); end
end

class BarType
def self.parse
end
def self.parse; end
end
end

Expand Down