Skip to content

Freeze the result of the call + some rubocop offenses. #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 7, 2018

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 7, 2018

No description provided.

@dblock dblock requested a review from myxoh December 7, 2018 02:00
@grape-bot
Copy link

grape-bot commented Dec 7, 2018

1 Warning
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#1837](https://github.com/ruby-grape/grape/pull/1837): Freeze the result of the call + some rubocop offenses.  - [@dblock](https://github.com/dblock).

Generated by 🚫 danger

@dblock dblock changed the title Freeze the result of the call. Freeze the result of the call + some rubocop offenses. Dec 7, 2018
Copy link
Member

@myxoh myxoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look good. Merging this

@myxoh myxoh merged commit 34610f5 into ruby-grape:master Dec 7, 2018
@dblock dblock deleted the freeze branch December 10, 2018 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants