Skip to content

Define Boolean for Grape::API::Instance #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 13, 2019
Merged

Define Boolean for Grape::API::Instance #1900

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
740f6f2
Define Boolean for Grape::API::Instance
Bhacaz Aug 2, 2019
ef6a88f
Added integration test.
Bhacaz Aug 2, 2019
4f7c114
Corrected CHANGELOG casing
Bhacaz Aug 2, 2019
ee9f504
Rewrite API::Instance spec
Bhacaz Aug 12, 2019
b6b49cd
Refactor spec file name and check params class
Bhacaz Aug 12, 2019
55cf260
Separated spec endpoint params type
Bhacaz Aug 13, 2019
995ecc1
Open `Grape::API::Instance` to set Boolean constant
Bhacaz Aug 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* Your contribution here.
* [#1893](https://github.com/ruby-grape/grape/pull/1893): Allows `Grape::API` to behave like a Rack::app in some instances where it was misbehaving - [@myxoh](https://github.com/myxoh).
* [#1898](https://github.com/ruby-grape/grape/pull/1898): Refactor ValidatorFactory to improve memory allocation - [@Bhacaz](https://github.com/Bhacaz).
* [#1900](https://github.com/ruby-grape/grape/pull/1900): Define boolean for grape::api::instance - [@Bhacaz](https://github.com/Bhacaz).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the casing of Grape::Api::Instance and quote it. Also quote ValidatorFactory above while we're at it, please.


### 1.2.4 (2019/06/13)

Expand Down
1 change: 1 addition & 0 deletions lib/grape/api/instance.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ class API
# The API Instance class, is the engine behind Grape::API. Each class that inherits
# from this will represent a different API instance
class Instance
Boolean = Virtus::Attribute::Boolean
include Grape::DSL::API

class << self
Expand Down