-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Define Boolean for Grape::API::Instance #1900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dblock
merged 7 commits into
ruby-grape:master
from
Bhacaz:define_boolean_for_api_instance
Aug 13, 2019
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
740f6f2
Define Boolean for Grape::API::Instance
Bhacaz ef6a88f
Added integration test.
Bhacaz 4f7c114
Corrected CHANGELOG casing
Bhacaz ee9f504
Rewrite API::Instance spec
Bhacaz b6b49cd
Refactor spec file name and check params class
Bhacaz 55cf260
Separated spec endpoint params type
Bhacaz 995ecc1
Open `Grape::API::Instance` to set Boolean constant
Bhacaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
require 'spec_helper' | ||
|
||
describe Grape::API::Instance do | ||
describe 'boolean constant' do | ||
module DefinesBooleanInstanceSpec | ||
class API < Grape::API | ||
params do | ||
requires :message, type: Boolean | ||
end | ||
post :echo do | ||
{ class: params[:message].class.name, value: params[:message] } | ||
end | ||
end | ||
end | ||
|
||
def app | ||
DefinesBooleanInstanceSpec::API | ||
end | ||
|
||
let(:expected_body) do | ||
{ class: 'TrueClass', value: true }.to_s | ||
end | ||
|
||
it 'sets Boolean as a Virtus::Attribute::Boolean' do | ||
post '/echo?message=true' | ||
expect(last_response.status).to eq(201) | ||
expect(last_response.body).to eq expected_body | ||
expect(DefinesBooleanInstanceSpec::API.new.router.map['POST'].first.options[:params]['message'][:type]).to eq 'Virtus::Attribute::Boolean' | ||
end | ||
end | ||
end |
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, write a separate spec with this line and put
params
assubject
orlet
. I'll stop after this I promise :)