-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Align implementation with Rack SPEC #1956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Here's an example of a CHANGELOG.md entry: * [#1956](https://github.com/ruby-grape/grape/pull/1956): Align implementation with rack spec - [@ioquatix](https://github.com/ioquatix). Generated by 🚫 danger |
I think this is okay to merge. @dblock |
👍 merged, although I do worry about |
Rack middleware must return an array of That being said, I understand your concern. |
Actually this changes broked our app after upgrade, check this one: #2030 (comment) |
Should we add something about this to https://github.com/ruby-grape/grape/blob/master/CHANGELOG.md#130-20200111 I ended up here looking into #1966 (while upgrading Rack due to its recent CVE) and it'd be great if the changelog called that out somehow |
@ghiculescu of course, go ahead! 🙂 |
|
Ref: ruby-grape#1956 Signed-off-by: Luong Vo <[email protected]>
Ref: ruby-grape#1956 Signed-off-by: Luong Vo <[email protected]>
And update specs/expand testing.