Skip to content

Force endpoint status in error_response and error! #2530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2025
Merged

Force endpoint status in error_response and error! #2530

merged 2 commits into from
Feb 1, 2025

Conversation

ericproulx
Copy link
Contributor

@ericproulx ericproulx commented Feb 1, 2025 •
edited
Loading

Following this comment, this PR fixes the issue with the endpoint's status when not invoking error! through a block or a helper.

@ericproulx ericproulx marked this pull request as ready for review February 1, 2025 16:42
@ericproulx ericproulx requested a review from dblock February 1, 2025 16:42
@ericproulx ericproulx mentioned this pull request Feb 1, 2025
Open
dblock
dblock approved these changes Feb 1, 2025
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@dblock dblock merged commit 2e0d33b into ruby-grape:master Feb 1, 2025
63 checks passed
@drewnichols drewnichols mentioned this pull request Feb 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericproulx @dblock