Skip to content

Fix declared_hash_attr when passed_params is not an Hash #2552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2025
Merged

Fix declared_hash_attr when passed_params is not an Hash #2552

merged 2 commits into from
Apr 5, 2025

Conversation

ericproulx
Copy link
Contributor

Fix #2551

@ericproulx ericproulx marked this pull request as ready for review April 5, 2025 13:36
@ericproulx
Add CHANGELOG.md
08d732f 
Fix rubocop
@ericproulx ericproulx requested a review from dblock April 5, 2025 13:41
@ericproulx ericproulx changed the title Fix declared_hash_attr where passed_params is not an Hash Fix declared_hash_attr when passed_params is not an Hash Apr 5, 2025
@dblock dblock merged commit 67ea152 into ruby-grape:master Apr 5, 2025
63 checks passed
@dblock
Copy link
Member

dblock commented Apr 5, 2025

If you git --amend your CHANGELOG and force push I can avoid squashing on merge ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock Awaiting requested review from dblock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'undefined method key?' when calling declared when params contain an empty array.
2 participants
@ericproulx @dblock