Added support for coercion to Set or Set[Other] #642
Conversation
I like Virtus's support for coercion to Sets as seen here: https://github.com/solnic/virtus#collection-member-coercions They can be treated the same as Arrays in the case of `nil`, and changing line 41 from `@option[0]` to `@option.first` behaves the same for either.
|
Looks good, however it needs tests, README and CHANGELOG updates. |
|
Awesome, I just wanted to run it by you first. A related issue that has come up in my own use of Grape is wanting to run the CoerceValidator after or between other validators, rather than always running it first. I can file a separate issue/request for this if it makes more sense, but here's a gist to illustrate: https://gist.github.com/jordansexton/260662acf75e66d9bf79 I like the idea of using validators to successively massage parameter values into the desired format, but I'm definitely new to Grape, so it's entirely possible I'm just approaching this wrong or duplicating an existing or preferred way of doing this, so please let me know what you think. |
|
You should open a separate issue. It would be definitely useful functionality. |
|
Bump. |
|
Closed via #995. |
I like Virtus's support for coercion to Sets as seen here:
https://github.com/solnic/virtus#collection-member-coercions
They can be treated the same as Arrays in the case of
nil, and changing line 42 from@option[0]to@option.firstbehaves the same for either.