This repository was archived by the owner on Jan 24, 2022. It is now read-only.
[ARMv6-M] initialize the LR register #293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: same as PR #292
the ARMv6-M Architecture Reference Manual (ARM DDI 0419D) indicates in section
B1.5.5 "Reset behavior" that the LR (Link Register) starts in an unknown state
when the Reset handler is taken and that its "Value must be initialised by
software"
So this PR does that: it initializes the LR register to 0xFFFF_FFFF (-1) first
thing in the Reset handler (only for v6). The manual doesn't say which value to
use so I decided to use the value used by the ARMv7-M (v7 sets LR to 0xFFFF_FFFF
before invoking the Reset handler; see its Architecture Manual for details).
The values of LR (these are pushed onto the stack in function preludes) are used
to unwind the stack (e.g. GDB's
backtrace
or a futurecortex_m_panic_unwind
handler). Having the initial stack frame use a known value on all Cortex-M
variants makes it easier to implement
panic_unwind
and avoids virtualunwinders like GDB
backtrace
trying to unwind beyond theReset
handlerNote that this implementation uses a trampoline that runs before
Reset
to setLR on v6. This is required because the prelude of the
Reset
routine will pushLR onto the stack; we want that LR value to be -1. Calling
register::lr::write
from
Reset
would perform the write after LR has been pushed onto the stack andthat's too late