Skip to content

Fix clippy warning #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2020
Merged

Fix clippy warning #222

merged 1 commit into from
Jun 6, 2020

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Jun 6, 2020

Explicitly allow manual non-exhaustive violations

@bugadani bugadani requested a review from a team as a code owner June 6, 2020 16:00
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ithinuel (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels Jun 6, 2020
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

For future reference #[non_exhaustive] is in Rust 1.40 onwards, we are currently MSRV 1.31, so it makes sense to allow this lint.

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 6, 2020

Build succeeded:

@bors bors bot merged commit c9c7539 into rust-embedded:master Jun 6, 2020
@bugadani bugadani deleted the fix-clippy branch June 6, 2020 16:45
adamgreig pushed a commit that referenced this pull request Jan 12, 2022
222: Bump the changelog for 0.6.11 r=adamgreig a=jonas-schievink

Unfortunately I already published it. Should we publish 0.6.12 just for this fix?

Co-authored-by: Jonas Schievink <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants