Better delay description #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CC #236 Signed-off-by: Daniel Egger <[email protected]>
|
r? @korken89 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
src/asm.rs
Outdated
| /// NOTE that the delay can take much longer if interrupts are serviced during its execution. | ||
| /// NOTE that the delay can take much longer if interrupts are serviced during its execution | ||
| /// and the execution time may wary with other factors. This delay is mainly useful for simple | ||
| /// timer-less initialisation of peripherals iff accurate timing is not essential. In any other |
There was a problem hiding this comment.
Suggested change
| /// timer-less initialisation of peripherals iff accurate timing is not essential. In any other | |
| /// timer-less initialization of peripherals if accurate timing is not essential. In any other |
There was a problem hiding this comment.
Hm, the iff is intended. I'm fine with changing the spelling to AE.
There was a problem hiding this comment.
Maybe expand it to "if and only if" then? iff tends to confuse people.
There was a problem hiding this comment.
Hm, I've never met anyone who was confused about that but sure, why not.
Co-authored-by: Jonas Schievink <[email protected]>
Signed-off-by: Daniel Egger <[email protected]>
Signed-off-by: Daniel Egger <[email protected]>
|
Build succeeded: |
Merged
bors bot
added a commit
that referenced
this pull request
Jul 20, 2020
249: More v0.6.3 backports r=jonas-schievink a=adamgreig I think this includes the remainder of the non-breaking changes since v0.6.2, with a couple of exceptions: * #240 seemed low-impact but had loads of separate commits to cherry-pick * #220 is I think non-breaking but was quite a substantial change, perhaps I could still include it ~~I did include #226 which adds a new field to `Peripherals`, but as I understand it that should be a non-breaking change since it's non-exhaustive.~~ I've updated the CHANGELOG with all the changes from this PR and the previous #248. Co-authored-by: Cliff L. Biffle <[email protected]> Co-authored-by: Peter Taylor <[email protected]> Co-authored-by: Hugues de Valon <[email protected]> Co-authored-by: Jonas Schievink <[email protected]> Co-authored-by: Adam Greig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC #236
Signed-off-by: Daniel Egger [email protected]