forbid sending interrupt tokens across interrupts #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which would break the `ctxt::Local` abstraction by making `Mutex` `Sync` only if the protected data is `Send`. See the CHANGELOG for details. To fully fix the memory unsafety, svd2rust needs to be updated to mark interrupt tokens as `!Send`
|
|
@homunkulus r+ |
|
📌 Commit 42968fc has been approved by |
|
☀️ Test successful - status-travis |
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
define handlers as weak aliases of DEFAULT_HANDLER
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which would break the
ctxt::Localabstraction by makingMutexSynconly ifthe protected data is
Send. See the CHANGELOG for details. To fully fix thememory unsafety, svd2rust needs to be updated to mark interrupt tokens as
!Sendcc @whitequark