Skip to content

xtask assemble fixes #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2020
Merged

xtask assemble fixes #285

merged 2 commits into from
Nov 4, 2020

Conversation

jonas-schievink
Copy link
Contributor

Closes #284

This is required for MIPS to work correctly, but not yet for Cortex-M
targets.
@rust-highfive
Copy link

r? @therealprof

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels Nov 4, 2020
Copy link
Member

@thalesfragoso thalesfragoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 4, 2020

Build succeeded:

@bors bors bot merged commit 5b5b8b1 into rust-embedded:master Nov 4, 2020
@jonas-schievink jonas-schievink deleted the fix-rasm branch January 25, 2021 00:00
adamgreig pushed a commit that referenced this pull request Jan 12, 2022
285: Try combining some steps to speed up CI r=jonas-schievink a=therealprof

Signed-off-by: Daniel Egger <[email protected]>

Co-authored-by: Daniel Egger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic handler removal does not work
4 participants