Expose __syscall and add new bootstrap method #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
Co-authored-by: Jonas Schievink <[email protected]>
jonas-schievink
previously approved these changes
Dec 2, 2020
Co-authored-by: Jonas Schievink <[email protected]>
|
Build succeeded: |
Merged
bors bot
added a commit
that referenced
this pull request
Jan 25, 2021
320: Prepare for v0.7.1 r=therealprof a=adamgreig Includes: * Deprecate msp::write #297 * New syscall and bootstrap ASM #299 * More compiler fences #311 * asm::delay timing fix #312 * asm::delay clobber fix #317 * LTO for ASM fix #318 Doesn't include anything to help with #304 which might be nice to fix but can come in 0.7.2 and might need some time to think about. Co-authored-by: Adam Greig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added
__syscallin the new inline asm, but did not expose it in the crate API, and the cortex-m-semihosting crate can't use it directly because the pre-built binaries would contain duplicate symbols (#271). This PR renames it to__sh_syscall(since we could imagine other different syscalls; this one is explicitly semihosting with thebkpt 0xAB) and exposes it incortex_m::asm::sh_syscall.This PR also adds the new methods discussed in #297 to permit sound bootstrapping, either from an MSP and RV or a vector table address.