Skip to content

Fix duplicated exception handlers. #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2017
Merged

Conversation

pftbest
Copy link
Contributor

@pftbest pftbest commented Jul 16, 2017

A workaround for rust-embedded/cortex-m#19

@japaric
Copy link
Member

japaric commented Jul 17, 2017

I'm hitting LLVM assertions when using this with the Cortex-M target:

#![no_std]

#[macro_use(interrupt)]
extern crate stm32f103xx;

fn main() {}

interrupt!(TIM2, tim2);

fn tim2() {}
$ tail Cargo.toml
[profile.release]
debug = true
lto = true

$ xargo build --release
rustc: /checkout/src/llvm/lib/MC/MCStreamer.cpp:294: virtual void llvm::MCStreamer::EmitLabel(llvm::MCSymbol*): Assertion `!Symbol->isVariable() && "Cannot emit a variable symbol!"' failed.

pftbest added a commit to pftbest/rust that referenced this pull request Jul 18, 2017
TimNN added a commit to TimNN/rust that referenced this pull request Jul 21, 2017
[LLVM] Fix an assertion when a weak symbol is defined in global_asm.

This change will fix the issue from
rust-embedded/svd2rust#130

cc @japaric
r? @alexcrichton
bors added a commit to rust-lang/rust that referenced this pull request Jul 21, 2017
[LLVM] Fix an assertion when a weak symbol is defined in global_asm.

This change will fix the issue from
rust-embedded/svd2rust#130

cc @japaric
r? @alexcrichton
@japaric
Copy link
Member

japaric commented Jul 22, 2017

@homunkulus r+

@homunkulus
Copy link
Contributor

📌 Commit f6aedfa has been approved by japaric

@homunkulus
Copy link
Contributor

⌛ Testing commit f6aedfa with merge f6aedfa...

@homunkulus
Copy link
Contributor

💔 Test failed - status-appveyor

@japaric
Copy link
Member

japaric commented Jul 22, 2017

@homunkulus r+

@homunkulus
Copy link
Contributor

📌 Commit b84f13a has been approved by japaric

@homunkulus
Copy link
Contributor

⌛ Testing commit b84f13a with merge b84f13a...

@homunkulus
Copy link
Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: japaric
Pushing b84f13a to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants