Skip to content

Get rid of a boatload of unnecessary braces warnings #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2020
Merged

Get rid of a boatload of unnecessary braces warnings #454

merged 1 commit into from
Jul 5, 2020

Conversation

therealprof
Copy link
Contributor 

warning: unnecessary braces around block return value
     --> src/lib.rs:22188:62
      |
22188 | pub fn variant ( self , variant : HSEBYP_A ) -> & 'a mut W { { self . bit ( variant . into ( ) ) } } # [ doc = "HSE crystal oscillator not bypassed" ]
      |                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these braces

Signed-off-by: Daniel Egger [email protected]

@therealprof
Get rid of a boatload of unnecessary braces errors
b9d9a49 
```
warning: unnecessary braces around block return value
     --> src/lib.rs:22188:62
      |
22188 | pub fn variant ( self , variant : HSEBYP_A ) -> & 'a mut W { { self . bit ( variant . into ( ) ) } } # [ doc = "HSE crystal oscillator not bypassed" ]
      |                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these braces
```

Signed-off-by: Daniel Egger <[email protected]>
@therealprof therealprof requested a review from a team as a code owner July 5, 2020 12:22
@rust-highfive
Copy link

r? @reitermarkus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jul 5, 2020
@burrbull
Copy link
Member

burrbull commented Jul 5, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 5, 2020

Build succeeded:

@bors bors bot merged commit 8b95499 into master Jul 5, 2020
@bors bors bot deleted the no-unnecessary-braces branch July 5, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burrbull burrbull burrbull approved these changes

Assignees

@reitermarkus reitermarkus

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@therealprof @rust-highfive @burrbull @reitermarkus