Skip to content

N14: OpenGL preprocessor #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2020
Merged

N14: OpenGL preprocessor #285

merged 3 commits into from
Oct 4, 2020

Conversation

krupitskas
Copy link

@krupitskas krupitskas commented Oct 2, 2020

Part of #278 ("Newsletter 14")

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good! There's a few grammar tweaks that would be nice to make:

"With the power of cargo build scripts full power of Tera, you can create advanced..." could be "With the full power of Cargo build scripts and Tera, you can create an advanced...".

"Last point especially problematic if..." could be "The last point is especially problematic if...".

"and create compile-time preprocessing tool..." could be "and create a compile-time preprocessing tool".

@ozkriff ozkriff mentioned this pull request Oct 4, 2020
49 tasks
@17cupsofcoffee
Copy link
Collaborator

Content looks good, just needs the lines wrapping at 80 characters to pass the CI check.

@ozkriff ozkriff changed the title Newsletter 14: OpenGL preprocessor N14: OpenGL preprocessor Oct 4, 2020
@ozkriff ozkriff merged commit d183ab8 into rust-gamedev:source Oct 4, 2020
@ozkriff
Copy link
Member

ozkriff commented Oct 4, 2020

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants