Skip to content
This repository was archived by the owner on Aug 16, 2021. It is now read-only.

try to fix issue #251 #252

Merged
merged 2 commits into from
Jun 4, 2019
Merged

try to fix issue #251 #252

merged 2 commits into from
Jun 4, 2019

Conversation

fogti
Copy link
Contributor

@fogti fogti commented Aug 18, 2018

I think that the following modification (seen in quick-error) could work here, to fix issue #251.
I splitted the problematic part in two parts:

  1. ignore unknown/renamed/removed lints
  2. disable warnings about unused doc comments

@fogti
Copy link
Contributor Author

fogti commented Aug 18, 2018

@AndyGauge
Copy link
Contributor

I'm trying to push for a release for some minor changes that have serious impact on users. If you don't mind, I would like to hold off on this one.

Copy link
Contributor

@AndyGauge AndyGauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does splitting the cfgs to separate lines fix the issue?

@fogti
Copy link
Contributor Author

fogti commented Jun 4, 2019

This fixes an issue with rustc 1.27.0 (and probably 1.28.0, too), which doesn't apply the (#allow) unknown_lints, renamed_and_removed_lints to unused_doc_comment, unused_doc_comments, when these lints-to-ignore are in the same line

@AndyGauge
Copy link
Contributor

Thanks, that was news to me!

@AndyGauge AndyGauge merged commit 63653c8 into rust-lang-deprecated:master Jun 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants