This repository was archived by the owner on Aug 16, 2021. It is now read-only.
Don't duplicate code for small-error #160
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you nest these inside an |
|
Sure! |
|
I would have named submodules |
|
I rebased and fixed this. :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, while implementing #159, I've noticed that I have to duplicate docstrings for small-error. I though that maybe we can get rid of this duplication, by separating the
ErrorAPI (which is the same for both cases) and the implementation (which actually differs). Not sure if it's worth doing this, but at least it seems to work =P