-
Notifications
You must be signed in to change notification settings - Fork 298
Author "Async Closures MVP: Call for Testing!" #1377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compiler-errors
commented
Aug 9, 2024
posts/inside-rust/2024-08-09-async-closures-call-for-testing.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2024-08-09-async-closures-call-for-testing.md
Outdated
Show resolved
Hide resolved
traviscross
approved these changes
Aug 9, 2024
posts/inside-rust/2024-08-09-async-closures-call-for-testing.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2024-08-09-async-closures-call-for-testing.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2024-08-09-async-closures-call-for-testing.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2024-08-09-async-closures-call-for-testing.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2024-08-09-async-closures-call-for-testing.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2024-08-09-async-closures-call-for-testing.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2024-08-09-async-closures-call-for-testing.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2024-08-09-async-closures-call-for-testing.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2024-08-09-async-closures-call-for-testing.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2024-08-09-async-closures-call-for-testing.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Travis Cross <[email protected]>
yoshuawuyts
approved these changes
Aug 10, 2024
compiler-errors
commented
Aug 12, 2024
posts/inside-rust/2024-08-09-async-closures-call-for-testing.md
Outdated
Show resolved
Hide resolved
The only case this can't happen is when inference infers an unnameable type
lcnr
reviewed
Aug 12, 2024
posts/inside-rust/2024-08-09-async-closures-call-for-testing.md
Outdated
Show resolved
Hide resolved
compiler-errors
commented
Aug 12, 2024
tmandry
approved these changes
Aug 14, 2024
posts/inside-rust/2024-08-09-async-closures-call-for-testing.md
Outdated
Show resolved
Hide resolved
b75327c
to
d630123
Compare
compiler-errors
commented
Aug 14, 2024
posts/inside-rust/2024-08-09-async-closures-call-for-testing.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2024-08-09-async-closures-call-for-testing.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2024-08-09-async-closures-call-for-testing.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2024-08-09-async-closures-call-for-testing.md
Outdated
Show resolved
Hide resolved
auto-merge was automatically disabled
August 14, 2024 18:16
Head branch was pushed to by a user without write access
compiler-errors
commented
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦
posts/inside-rust/2024-08-09-async-closures-call-for-testing.md
Outdated
Show resolved
Hide resolved
I don't have merge rights. Can someone merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat rough draft, but I think it has all the components necessary for a call-for-testing post. Given that it's an internals post, I leaned towards being a bit technical here.
If anyone has strong opinions about how this should be structured, let me know down below, but let's not bikeshed this forever -- I'd really like to get something out to point people at so they can test out async closures 😸
cc @rust-lang/wg-async @rust-lang/lang