Skip to content

Don't default-italicize blockquote text #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2025

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented May 25, 2025

Default-italicizing blockquote text prevents *italics* markdown from having an observable effect.

Fixes #1617. I was not able to reproduce the extra spacing on the blockquote locally.

Preview

Screenshot 2025-05-25 191133

Testing

You can try out this locally to reproduce the preview above with an example post like

+++
path = "9999/12/31/DO_NOT_MERGE_example"
title = "[DO NOT MERGE] Example"
authors = ["Ferris"]
+++

Prior text.

> This is an example blockquote.
>
> Normal text.
>
> *Italicized text*.
>
> Last sentence, does this have excessive whitespace afterwards? Lorem ipsum dolor sit amet, consectetur adipiscing elit. Proin quis ex lacus. Morbi vitae dignissim justo, ac pellentesque felis. Suspendisse at magna in ipsum euismod cursus. Nam sed tristique sem. Quisque efficitur tincidunt tortor, imperdiet interdum sem pharetra sed. Sed dapibus tortor eros, pellentesque auctor augue faucibus vitae.

Trailing text.

r? @senekor

Default italicizing blockquote text prevents `*italics*` markdown from
having an observable effect.
Copy link
Contributor

@senekor senekor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@senekor senekor merged commit c65edf7 into rust-lang:master May 25, 2025
5 checks passed
@jieyouxu jieyouxu deleted the blockquotes branch May 30, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style nit: block quotes italicize text by default and *italics* is no-op, losing expressiveness
2 participants