Skip to content

Rename rustc-guide -> rustc-dev-guide #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 13, 2020
Merged

Conversation

mark-i-m
Copy link
Member

@mark-i-m mark-i-m commented Mar 8, 2020

cc @rust-lang/wg-learning

To be merged on monday after we rename the repo...

@chrissimpkins
Copy link
Member

chrissimpkins commented Mar 8, 2020

Doesn't seem to like the @ in your author field

https://travis-ci.com/rust-lang/blog.rust-lang.org/builds/152294983#L212

mark-i-m and others added 2 commits March 9, 2020 09:32
@nikomatsakis
Copy link
Contributor

@mark-i-m should this be merged now?

@mark-i-m
Copy link
Member Author

mark-i-m commented Mar 9, 2020

@nikomatsakis Thanks :) Not yet, as we haven't actually done the rename yet, and I need to update it.

@nikomatsakis
Copy link
Contributor

@mark-i-m now? :)

@mark-i-m
Copy link
Member Author

Personally, I think so, but I think @spastorino wanted to wait until we had finished fixing toolstate.

@pietroalbini
Copy link
Member

I don't think we should block on that, it's just an implementation detail of the rustc repo.

Copy link
Member

@chrissimpkins chrissimpkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links all LGTM 👍

@spastorino
Copy link
Member

Yes, this could be merged now I think. I didn't say I wanted to wait for toolstate, I believe :).

@nikomatsakis nikomatsakis merged commit c0569d6 into rust-lang:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants