Skip to content

Draft blog post for my retirement from TWiR. #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 13, 2020
Merged

Draft blog post for my retirement from TWiR. #542

merged 7 commits into from
Mar 13, 2020

Conversation

nasa42
Copy link
Member

@nasa42 nasa42 commented Mar 12, 2020

As suggested by @XAMPPRocky in Community team mailing list, I'm submitting this PR for a post in Inside Rust blog.

Please do review for grammar and let me know if it can be improved. Also, I'd appreciate if I'm not attributed as the author of post (as I've written the post in third-person, because I noticed that all such posts are in third-person).

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

XAMPPRocky
XAMPPRocky reviewed Mar 12, 2020
View reviewed changes
Copy link
Member

@XAMPPRocky XAMPPRocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Vikrant for making the this post, and for all your work on This Week In Rust! 😃

bjorn3
bjorn3 reviewed Mar 12, 2020
View reviewed changes
Copy link
Member

@bjorn3 bjorn3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all those years of TWiR!

@nikomatsakis
Copy link
Contributor

this looks great, shall we post? Are there any timing constraints?

(And thanks to Vikrant indeed.)

@XAMPPRocky
Copy link
Member

@nikomatsakis Yeah, I wanted to wait till after release day to post so it didn't get lost in the noise.

@XAMPPRocky XAMPPRocky merged commit 8a3ee85 into rust-lang:master Mar 13, 2020
steveklabnik pushed a commit that referenced this pull request Mar 27, 2020
@nasa42 @XAMPPRocky @steveklabnik
Draft blog post for my retirement from TWiR. (#542)
1d9c020 
* Draft blog post for my retirement from TWiR.

* Update posts/inside-rust/2020-03-12-twir-new-lead.md

Co-Authored-By: XAMPPRocky <[email protected]>

* Update posts/inside-rust/2020-03-12-twir-new-lead.md

Co-Authored-By: XAMPPRocky <[email protected]>

* Update posts/inside-rust/2020-03-12-twir-new-lead.md

Co-Authored-By: XAMPPRocky <[email protected]>

* Update posts/inside-rust/2020-03-12-twir-new-lead.md

Co-Authored-By: XAMPPRocky <[email protected]>

* Update 2020-03-12-twir-new-lead.md

* Rename 2020-03-12-twir-new-lead.md to 2020-03-13-twir-new-lead.md

Co-authored-by: XAMPPRocky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XAMPPRocky XAMPPRocky XAMPPRocky left review comments

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nasa42 @rust-highfive @nikomatsakis @XAMPPRocky @bjorn3