Skip to content

Don't compare User-Agent in http_auth_offered test #5306

Closed
@tcely

Description

@tcely

I don't understand why User-Agent header is listed as part of valid.

I checked the commits and it seems like you're constantly updating the version strings shown in this header for libgit2 which is as far as I know not a version you control. It seems like this has nothing to do with the test and should just be removed from the valid headers list.

See: https://github.com/rust-lang/cargo/blob/0.26.0/tests/build-auth.rs#L23

Also, Accept doesn't seem to be under test here and doesn't change. I'm not sure why it should be in this list either.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions